Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor SslHandler.setWrapDataSize greater than SSL packet length #13551

Merged
merged 3 commits into from Aug 18, 2023

Commits on Aug 16, 2023

  1. Honor SslHandler.setWrapDataSize greater than SSL packet length

    Motivation:
    
    When processing large responses, chunking them into many 16kb chunks
    causes excessive load on PoolArena which slows down AbstractUnsafe.flush0.
    
    Modifications:
    
    Allocate an outNetBuf based on setWrapDataSize. If setWrapDataSize is larger
    than SSL packet length, iteratively slice the data buffer, encrypting chunks
    into the one larger buffer.
    
    Reduce unnecessary composition in AbstractCoalescingBufferQueue when a call
    to remove() only needs to process one buffer.
    
    Result:
    
    Eliminate contention in PoolArena relative to splitting large responses,
    thus increasing overall throughput and reducing overall memory pressure.
    
    Relates to netty#13549
    bbeaudreault committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    26ab44a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. updates from testing

    bbeaudreault committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    364da93 View commit details
    Browse the repository at this point in the history
  2. Share logic

    normanmaurer committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f39ebcf View commit details
    Browse the repository at this point in the history