Enable client side session cache when using native SSL by default #13562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When we introduced support for client side session caching for our native SSL implementation we disabled it by default as some java versions had a bug that could result in a NPE. This was fixed for all java versions >= 8 for a while. Let's enable it by default so people will receive the performance gains with the need to adjust properties. Related JDK ticket: https://bugs.openjdk.org/browse/JDK-8241248 Modifications: Set io.netty.handler.ssl.openssl.sessionCacheClient to true by default Result: Enable client session caching by default.
|
/cc @trustin |
|
Do we have an end-to-end caching unit test? |
|
@hyperxpro yes tests are already there |
hyperxpro
reviewed
Aug 22, 2023
| @@ -115,10 +115,8 @@ public abstract class ReferenceCountedOpenSslContext extends SslContext implemen | |||
|
|
|||
| static final boolean SERVER_ENABLE_SESSION_CACHE = | |||
| SystemPropertyUtil.getBoolean("io.netty.handler.ssl.openssl.sessionCacheServer", true); | |||
| // session caching is disabled by default on the client side due a JDK bug: | |||
There was a problem hiding this comment.
Let's update this comment then stating it is now enabled from being disabled previously. Also, let's add a logger for this in the static block so people can explicitly know that it's turned on now.
There was a problem hiding this comment.
honestly I think there is no need for a comment or static logger
chrisvest
approved these changes
Aug 22, 2023
normanmaurer
added a commit
that referenced
this pull request
Aug 24, 2023
…3562) Motivation: When we introduced support for client side session caching for our native SSL implementation we disabled it by default as some java versions had a bug that could result in a NPE. This was fixed for all java versions >= 8 for a while. Let's enable it by default so people will receive the performance gains with the need to adjust properties. Related JDK ticket: https://bugs.openjdk.org/browse/JDK-8241248 Modifications: Set io.netty.handler.ssl.openssl.sessionCacheClient to true by default Result: Enable client session caching by default.
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Aug 30, 2023
netty/netty#13562 This change enables client side session cache when using native SSL by default The current CI build with Netty SNAPSHOT fails https://github.com/reactor/reactor-netty/actions/runs/6025947526
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Aug 30, 2023
netty/netty#13562 This change enables client side session cache when using native SSL by default The current CI build with Netty SNAPSHOT fails https://github.com/reactor/reactor-netty/actions/runs/6025947526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When we introduced support for client side session caching for our native SSL implementation we disabled it by default as some java versions had a bug that could result in a NPE. This was fixed for all java versions >= 8 for a while. Let's enable it by default so people will receive the performance gains with the need to adjust properties.
Related JDK ticket:
https://bugs.openjdk.org/browse/JDK-8241248
Modifications:
Set io.netty.handler.ssl.openssl.sessionCacheClient to true by default
Result:
Enable client session caching by default.