Filter out unresolved addresses when parsing resolv.conf #13614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
resolv_conf
branch
from
dac35ca
to
c07fcf4
Compare
chrisvest
requested changes
Sep 18, 2023
| // address is used with a scope that represent a network interface that does not exists | ||
| // on the host. | ||
| if (!addr.isUnresolved()) { | ||
| addresses.add(SocketUtils.socketAddress(maybeIP, port)); |
There was a problem hiding this comment.
We can reuse the addr variable here, instead of recreating the InetSocketAddress object.
Motivation: We need to filter out unresolved addresses when parsing resolv.conf as otherwise we might throw an exception while initialize the default address provider. Modifications: Only add address when its resolvable Result: Fixes #13612
normanmaurer
force-pushed
the
resolv_conf
branch
from
c07fcf4
to
d231ca6
Compare
normanmaurer
added a commit
that referenced
this pull request
Sep 19, 2023
Motivation: We need to filter out unresolved addresses when parsing resolv.conf as otherwise we might throw an exception while initialize the default address provider. Modifications: Only add address when its resolvable Result: Fixes #13612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to filter out unresolved addresses when parsing resolv.conf as otherwise we might throw an exception while initialize the default address provider.
Modifications:
Only add address when its resolvable
Result:
Fixes #13612