Speedup max direct memory estimation via Unsafe #13650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
force-pushed
the
max_d_mem_unsafe
branch
from
fe9c453
to
b1717b8
Compare
normanmaurer
reviewed
Oct 6, 2023
| terminationFuture.setSuccess(null); | ||
| } | ||
| } | ||
| doShutdown(success); |
There was a problem hiding this comment.
@franz1981 please revert... this is not related
normanmaurer
requested changes
Oct 6, 2023
Motivation: PlatformDependent::estimateMaxDirectMemory reflectevly allocates MX Beans to detect JVM's arg MaxDirectMemory (often failing to find any, because unconfigured). Modifications: Allow unsafe to find Bits's max memory static field and use it as a fast path to detect the same direct memory limits used by the JVM runtime Result: Faster and less memory hungry (in term of mallocs) startup
franz1981
force-pushed
the
max_d_mem_unsafe
branch
from
b1717b8
to
86bba39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
PlatformDependent::estimateMaxDirectMemory reflectevly allocates MX Beans to detect JVM's arg MaxDirectMemory (often failing to find any, because unconfigured).
Modifications:
Allow unsafe to find Bits's max memory static field and use it as a fast path to detect the same direct memory limits used by the JVM runtime
Result:
Faster and less memory hungry (in term of mallocs) startup
Porting of #13643