Make transport and MockTicker tests more stable #13713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A number of flaky tests were identified. Modification: Address test isolation failures and resource exhaustion errors. Also enable parallel test execution, becuase the tests can probably tolerate that now. Result: Tests in the transport module should now run stable enough to run in parallel.
chrisvest
force-pushed
the
5x-transport-tests
branch
from
cdba967
to
87949f9
Compare
Also made the test run dramatically faster. We don't need to wait that long to confirm that a future hasn't completed.
| Thread.sleep(50); | ||
| } catch (InterruptedException e) { | ||
| // Ignore | ||
| } | ||
| allTimeStampsLatch.countDown(); | ||
| }, 100, 100, TimeUnit.MILLISECONDS); |
There was a problem hiding this comment.
Are these windows a bit stingy? It seems pretty easy for a CI thread to lose 100 ms.
transport/src/test/java/io/netty5/channel/nio/NioEventLoopTest.java
Outdated
Show resolved
Hide resolved
common/src/test/java/io/netty5/util/concurrent/DefaultMockTickerTest.java
Show resolved
Hide resolved
|
|
The test tended to run out of memory by filling up the executor task queue.
bryce-anderson
approved these changes
Dec 1, 2023
|
Panama build looks like it got stuck on uploading its docker cache. |
chrisvest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A number of flaky tests were identified.
Modification:
Address test isolation failures and resource exhaustion errors.
Also enable parallel test execution, becuase the tests can probably tolerate that now.
Improve the DefaultMockTicker test to be deterministic, by adding the ability to wait for other threads to enter the sleep method.
Result:
Tests in the transport module should now run stable enough to run in parallel.
All the tests can now also be run in repeat.