Transport: AdaptiveRecvByteBufAllocator does not correctly calculate … #13882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initial buffer capacity in some cases Motivation: We did not correctly calculate the initial index sometimes which could lead to the initial buffer capacity to exceed the configured maximum size. Modifications: - Correctly calculate initialIndex - Add unit tests Result: Fixes #13722
chrisvest
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
The change itself looks good.
I noticed an issue in the existing logic constraining the indexes, that if you create a new AdaptiveRecvByteBufAllocator(81, 95, 95), for instance, the min index will be larger than the initial and max indexes, and it'll produce an initial allocation of size 80 even though the minimum size is 81.
|
@chrisvest got it…. let me fix this in a followup |
|
@chrisvest fixed.... PTAL again |
chrisvest
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…initial buffer capacity in some cases
Motivation:
We did not correctly calculate the initial index sometimes which could lead to the initial buffer capacity to exceed the configured maximum size.
Modifications:
Result:
Fixes #13722