Avoid copying of MqttPublishMessage.payload byte buffer #13939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
requested changes
Apr 20, 2024
| @@ -453,6 +453,7 @@ private static ByteBuf encodePublishMessage( | |||
| return buf; | |||
| } finally { | |||
| propertiesBuf.release(); | |||
| payload.release(); | |||
There was a problem hiding this comment.
I will need to check in details but if this is needed here it was also needed in the original code
There was a problem hiding this comment.
Yeah, there is a back comparability issue. Maybe you have some ideas to avoid it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
MqttMessageBuildersmake unnecessary copies of Publish message payload,which takes up extra CPU and memory.Most user cases allow avoiding this.
Modification:
Remove payload copying in
MqttMessageBuilders.PublishBuilderand duplicating inMqttEncoder.Result:
Less CPU and memory usage.
Fixes #13844