ByteBuf.asReadOnly().nioBuffer*() need to return read-only ByteBuffer #14078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @lhotari |
chrisvest
approved these changes
May 24, 2024
Motivation: We need to ensure that the returned ByteBuffers are also read-only if the ByteBuf is read-only. Modifications: - Correctly return read-only ByteBuffers - Add unit tests Result: Return correct type of ByteBuffers
normanmaurer
force-pushed
the
read_only_nio_buffers
branch
from
325da55
to
88277d6
Compare
normanmaurer
added a commit
that referenced
this pull request
May 24, 2024
…#14078) Motivation: We need to ensure that the returned ByteBuffers are also read-only if the ByteBuf is read-only. Modifications: - Correctly return read-only ByteBuffers - Add unit tests Result: Return correct type of ByteBuffers
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to ensure that the returned ByteBuffers are also read-only if the ByteBuf is read-only.
Modifications:
Result:
Return correct type of ByteBuffers