Fix API compat issue for users that upgrade from 4.1.x to 4.2.0 #14120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
One API compat issue was detected by servicetalk. We need to fix it:
```
/home/runner/work/servicetalk/servicetalk/servicetalk-dns-discovery-netty/src/main/java/io/servicetalk/dns/discovery/netty/DnsResolverAddressTypes.java:66: error: reference to computeResolvedAddressTypes is ambiguous
return fromNettyType(DnsNameResolverBuilder.computeResolvedAddressTypes());
^
both method computeResolvedAddressTypes(io.netty.channel.socket.InternetProtocolFamily...) in io.netty.resolver.dns.DnsNameResolverBuilder and method computeResolvedAddressTypes(io.netty.channel.socket.SocketProtocolFamily...) in io.netty.resolver.dns.DnsNameResolverBuilder match
Note: Some input files use or override a deprecated API.
> Task :servicetalk-dns-discovery-netty:compileJava FAILED
```
Modifications:
Rename method to fix compat
Result:
Be able to use 4.2.0 where 4.1.x was used
daschl
approved these changes
Jun 13, 2024
chrisvest
approved these changes
Jun 13, 2024
idelpivnitskiy
approved these changes
Jun 13, 2024
|
@metlos This looks like a rare case where revapi didn't flag a potential compatibility issue, FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
One API compat issue was detected by servicetalk. We need to fix it:
Modifications:
Rename method to fix compat
Result:
Be able to use 4.2.0 where 4.1.x was used