Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ability to use Executor instead of ThreadFactory #1762
Netty is widely used in IntelliJ IDEA — java compiler server, built-in server (xmlrpc, json), built-in web server, js debuggers and so on. I have tried to migrate to Netty 4, but encountered a problem — we cannot use now our shared (application level) executor service. We cannot use thread factory — application doesn't expose it and you cannot create threads, you must use shared pool of threads (exposed as executor service).
Please review my pull request:
may be is not good solution (without it test SingleThreadEventLoopTest.scheduleLaggyTaskAtFixedRateB will be failed) but all works and I have tried to minimise my changes.