New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2209] Allow to cancel non-flushed writes #2214

Closed
wants to merge 3 commits into
base: 4.0
from

Conversation

Projects
None yet
2 participants
@normanmaurer
Member

normanmaurer commented Feb 7, 2014

Proposed fix for #2209

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Feb 7, 2014

Member

@trustin let me know what you think. I'm not sure yet if we really want to support cancel writes at all.

Member

normanmaurer commented Feb 7, 2014

@trustin let me know what you think. I'm not sure yet if we really want to support cancel writes at all.

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Feb 7, 2014

Member

Beside this. i think we also need to take care of handle cancelation for other io operations like close. Somethink like call setUncancellable() and check the return value before really do the operation

Member

normanmaurer commented Feb 7, 2014

Beside this. i think we also need to take care of handle cancelation for other io operations like close. Somethink like call setUncancellable() and check the return value before really do the operation

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 7, 2014

Build result for #2214 at 4ae8c33: Success

ghost commented Feb 7, 2014

Build result for #2214 at 4ae8c33: Success

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Feb 8, 2014

Member

@trustin please check again... running benchmark now

Member

normanmaurer commented Feb 8, 2014

@trustin please check again... running benchmark now

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 8, 2014

Build result for #2214 at b518024: Success

ghost commented Feb 8, 2014

Build result for #2214 at b518024: Success

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Feb 8, 2014

Member

No speed difference

Member

normanmaurer commented Feb 8, 2014

No speed difference

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 8, 2014

Build result for #2214 at 8b224cf: Success

ghost commented Feb 8, 2014

Build result for #2214 at 8b224cf: Success

@xfrag xfrag referenced this pull request Feb 9, 2014

Closed

Cancel writes on 5.0 #2218

trustin added a commit that referenced this pull request Feb 10, 2014

Make most outbound operations are cancellable
- Inspired by #2214
- It actually reduces the chance of trying to marking a cancelled promise as success again, which raises an IllegalStateException.

trustin added a commit that referenced this pull request Feb 10, 2014

Make most outbound operations are cancellable
- Inspired by #2214
- It actually reduces the chance of trying to marking a cancelled promise as success again, which raises an IllegalStateException.

trustin added a commit that referenced this pull request Feb 10, 2014

Make most outbound operations cancellable / More robust promise update
- Inspired by #2214 by @normanmaurer
- Call setUncancellable() before performing an outbound operation
- Add safeSetSuccess/Failure() and use them wherever

trustin added a commit that referenced this pull request Feb 10, 2014

Make most outbound operations cancellable / More robust promise update
- Inspired by #2214 by @normanmaurer
- Call setUncancellable() before performing an outbound operation
- Add safeSetSuccess/Failure() and use them wherever
@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Feb 11, 2014

Member

@trustin please review again

Member

normanmaurer commented Feb 11, 2014

@trustin please review again

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 11, 2014

Build result for #2214 at a957f3f: Success

ghost commented Feb 11, 2014

Build result for #2214 at a957f3f: Success

@trustin

This comment has been minimized.

Show comment
Hide comment
@trustin

trustin Feb 11, 2014

Member

LGTM. Please merge.

Member

trustin commented Feb 11, 2014

LGTM. Please merge.

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Feb 11, 2014

Member

@trustin cherry-picked into 4.0 and master

Member

normanmaurer commented Feb 11, 2014

@trustin cherry-picked into 4.0 and master

@normanmaurer normanmaurer added this to the 4.0.16.Final milestone Feb 11, 2014

@normanmaurer normanmaurer deleted the cancel_writes branch Mar 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment