Allow efficient writing of CompositeByteBuf when using native epoll tran... #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trustin please review |
|
@trustin ok now it is correct. please review |
| // passed to write. | ||
| buf = newDirectBuffer(buf); | ||
| assert buf.hasMemoryAddress(); | ||
| boolean isDirect = buf.isDirect(); |
There was a problem hiding this comment.
This should not be evaluated when buf.hasMemoryAddress() returns true or PlatformDependent.hasUnsafe() returns true. We should not evaluate it at least when buf.hasMemoryAddress() returns true.
|
Looks good. Please merge once my comment is addressed. |
normanmaurer
force-pushed
the
epoll_composite_write
branch
from
5965394
to
d93b8eb
Compare
…ransport. Motivation: There were no way to efficient write a CompositeByteBuf as we always did a memory copy to a direct buffer in this case. This is not needed as we can just write a CompositeByteBuf as long as all the components are buffers with a memory address. Modifications: - Write CompositeByteBuf which contains only direct buffers without memory copy - Also handle CompositeByteBuf that have more components then 1024. Result: More efficient writing of CompositeByteBuf.
normanmaurer
force-pushed
the
epoll_composite_write
branch
from
d93b8eb
to
6f09efc
Compare
|
@trustin cherry-picked into 4.0, 4.1 and master after addressing your comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...sport.
Motivation:
There were no way to efficient write a CompositeByteBuf as we always did a memory copy to a direct buffer in this case. This is not needed as we can just write a CompositeByteBuf as long as all the components are buffers with a memory address.
Modifications:
Result:
More efficient writing of CompositeByteBuf.