Fix AbstractDiskHttpData int conversion from long #3210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivations: The chunkSize might be oversized after comparison (size being > of int capacity) if file size is bigger than an integer. Modifications: Changing the type to long fix the issue. Result: There is no more int oversized.
fredericBregier
force-pushed
the
3.9-fix-AbstractDiskHttpData-int-from-long
branch
from
0f36d8e
to
15736ed
Compare
|
@fredericBregier thanks... cherry-picked into 3.9 |
fredericBregier
deleted the
3.9-fix-AbstractDiskHttpData-int-from-long
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations:
The chunkSize might be oversized after comparison (size being > of int capacity) if file size is bigger than an integer.
Modifications:
Removing the test and changing of chunkSize value, letting it be standard at 8K.
Result:
There is no need to change the chunksize as it has not to be less or equal to the number of bytes available.
There is no more int oversized.