HTTP/2 ConnectionHandler close cleanup #3865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmittler PTAL. |
Motiviation: The connection handler stream close operation is unconditionally adding a listener object to a future. We may not have to add a listener at all because the future has already been completed. Modifications: - If the future is done, directly invoke the logic without creating/adding a new listener. Result: No need to create/add listener if the future is already done in close logic.
Scottmitch
force-pushed
the
http2_shutdown_cleanup
branch
from
41931e2
to
f3b8d07
Compare
|
@Scottmitch looks good |
|
@Scottmitch LGTM |
Scottmitch
added a commit
that referenced
this pull request
Jun 8, 2015
Motiviation: #3865 was merged from a machine with old code. A test case that was updates was not merged. Modifications: - Merge the missing test case updates Result: Test case no longer fails.
Scottmitch
added a commit
that referenced
this pull request
Jun 8, 2015
Motiviation: #3865 was merged from a machine with old code. A test case that was updates was not merged. Modifications: - Merge the missing test case updates Result: Test case no longer fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motiviation:
The connection handler stream close operation is unconditionally adding a listener object to a future. We may not have to add a listener at all because the future has already been completed.
Modifications:
Result:
No need to create/add listener if the future is already done in close logic.