Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper shutdown of HTTP2 encoder when channelInactive #3961

Closed
wants to merge 2 commits into from
Closed

Proper shutdown of HTTP2 encoder when channelInactive #3961

wants to merge 2 commits into from

Commits on Jul 8, 2015

  1. Proper shutdown of HTTP2 encoder when channelInactive 

    Motivation:

The problem is described in grpc/grpc-java#605. Basically, when using `StreamBufferingEncoder` there is a chance of creating zombie streams that never get closed.

Modifications:

Change `Http2ConnectionHandler`'s `channelInactive` handling logic to shutdown the encoder/decoder before shutting down the active streams.

Result:

Fixes grpc/grpc-java#605
    nmittler committed Jul 8, 2015
    Configuration menu
    Copy the full SHA
    7ebc11e View commit details
    Browse the repository at this point in the history

  2. addressing comments.

    nmittler committed Jul 8, 2015
    Configuration menu
    Copy the full SHA
    695eccb View commit details
    Browse the repository at this point in the history