Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4435] Always invoke the actual deregisteration later in the EventLoop. #4621

Closed
wants to merge 1 commit into from
Closed

[#4435] Always invoke the actual deregisteration later in the EventLoop. #4621

wants to merge 1 commit into from

Commits on Dec 24, 2015

  1. [#4435] Always invoke the actual deregisteration later in the EventLoop. 

    Motivation:

As a user may call deregister() from within any method while doing processing in the ChannelPipeline,  we need to ensure we do the actual deregister operation later. This is needed as for example,  we may be in the ByteToMessageDecoder.callDecode(...) method and so still try to do processing in the old EventLoop while the user already registered the Channel to a new EventLoop. Without delay, the deregister operation this could lead to have a handler invoked by different EventLoop and so threads.

Modifications:

Ensure the actual deregister will be done later on and not directly when invoked.

Result:

Calling deregister() within ByteToMessageDecoder.decode(..) is safe.
    @normanmaurer
    normanmaurer committed Dec 24, 2015
    Configuration menu
    Copy the full SHA
    8283e4d View commit details
    Browse the repository at this point in the history