[#4736] Clear disabled SSL protocols before enabling provided SSL pro… #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tocols Motivation: Attempts to enable SSL protocols which are currently disable fail when using the OpenSslEngine. Related to #4736 Modifications: Clear out all options that have disabled SSL protocols before attempting to enable any SSL protocol. Result: setEnabledProtocols works as expected.
|
@normanmaurer yep but with the last change you requested from @blucas, figured if you are in a rush this would help. |
|
@normanmaurer he would still be claimed as the author since I didn't amend the author in history ( see johnou@04678d7 ). |
|
@johnou I see... could you then please address my comment here: |
|
@normanmaurer would you please try reopening this PR to see if the commit updates from my branch? |
|
.. or we could leave it closed, looks like blucas is online. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tocols
Motivation:
Attempts to enable SSL protocols which are currently disable fail when using the OpenSslEngine. Related to #4736
Modifications:
Clear out all options that have disabled SSL protocols before attempting to enable any SSL protocol.
Result:
setEnabledProtocols works as expected.