SockJS Protocol support for Netty. #4997
Conversation
Motivation: Provide support for SockJS [1] which is a WebSocket emulation protocol which can fallback to different protocol in case WebSocket support in not supported. Modifications: Added a codes-sockjs module which contains all the code. Result: SockJS clients can now be used with a Netty server configured with SockJS. Credits: This is just a rebase of the pull request [2] by @danbev [1] https://github.com/sockjs [2] #3046
|
@eun-ice I will review this soon but that said I think this will not make it into 4.1.0 |
|
@normanmaurer thank you very much. If it's not going to make it into 4.1.0 I will publish this as a separate module and create a new pull request for 5.0. |
|
@Scottmitch thanks for the heads-up. |
|
Glad to see the interest in this again. Let me know if there is anything I can help out with. |
|
@danbev great to hear you are still around. If you want to help you could review my changes to your pull request. It's just a few lines changed https://github.com/netty/netty/files/177875/rebase-danbev-netty-sockjs-4.1.patch.zip |
|
@eun-ice This looks good to me! If possible could we keep this in the original PR so that we don't have two different ones for the same thing? |
|
@danbev feel free to close this PR, it is all your work. |
|
closed in favor of #3046 |
Motivation:
Provide support for SockJS [1] which is a WebSocket emulation protocol
which can fallback to different protocol in case WebSocket support in
not supported.
Modifications:
Added a codes-sockjs module which contains all the code.
Result:
SockJS clients can now be used with a Netty server configured with
SockJS.
Credits:
This is just a rebase of the pull request #3046 by @danbev
[1] https://github.com/sockjs