Change DefaultChannelId visibility to default. Related to [#5053] #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Scottmitch @nmittler @trustin PTAL |
| /** | ||
| * Create and return a new {@link ChannelId} instance. | ||
| */ | ||
| public static ChannelId newInstance() { |
There was a problem hiding this comment.
Should return DefaultChannelId given that this method is the factory method of DefaultChannelId?
There was a problem hiding this comment.
@trustin does it make any difference though ?
There was a problem hiding this comment.
Yeah, I'm happy. 😆 Consistency matters!
normanmaurer
force-pushed
the
public_default_channel_id
branch
from
1195718
to
66b4a7c
Compare
| @@ -53,7 +53,10 @@ | |||
|
|
|||
| private static final AtomicInteger nextSequence = new AtomicInteger(); | |||
|
|
|||
| static ChannelId newInstance() { | |||
| /** | |||
| * Create and return a new {@link DefaultChannelId} instance. | |||
There was a problem hiding this comment.
I still think Returns a new ... implies that it creates a new instance and returns it. i.e.
- 'create' is redundant.
- It should be 'returns' instead of 'return', because it's not an imperative sentence.
Motivation: There is no need to make DefaultChannelId package private as it may be useful for the user. For example EmbeddedChannel allows to inject a ChannelId when it is constructed. For this case the user can just use DefaultChannelId. Modifications: Change visibility of DefaultChannelId to public. Result: It's possible to create a new instance of DefaultChannelId by the user.
normanmaurer
force-pushed
the
public_default_channel_id
branch
from
66b4a7c
to
2f14d41
Compare
|
👏 LGTM 👍 |
|
Cherry-picked into 4.1 (2facb7a) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There is no need to make DefaultChannelId package private as it may be useful for the user. For example EmbeddedChannel allows to inject a ChannelId when it is constructed. For this case the user can just use DefaultChannelId.
Modifications:
Change visibility of DefaultChannelId to public.
Result:
It's possible to create a new instance of DefaultChannelId by the user.