OpenSslEngine writePlaintextData WANT_READ with no data in BIO buffer

[Scottmitch]

Motivation:
CVE-2016-4970

OpenSslEngine.wrap calls SSL_write which may return SSL_ERROR_WANT_READ, and if in this condition there is nothing to read from the BIO the OpenSslEngine and SslHandler will enter an infinite loop.

Modifications:

• Use the error code provided by OpenSSL and go back to the EventLoop selector to detect if the socket is closed

Result:
OpenSslEngine correctly handles the return codes from OpenSSL and does not enter an infinite loop.

[normanmaurer]

Go for it!

Am 07.06.2016 um 17:58 schrieb Scott Mitchell notifications@github.com:

Motivation:
CVE-2016-4970

OpenSslEngine.wrap calls SSL_write which may return SSL_ERROR_WANT_READ, and if in this condition there is nothing to read from the BIO the OpenSslEngine and SslHandler will enter an infinite loop.

Modifications:

Use the error code provided by OpenSSL and go back to the EventLoop selector to detect if the socket is closed
Result:
OpenSslEngine correctly handles the return codes from OpenSSL and does not enter an infinite loop.

You can view, comment on, or merge this pull request online at:

#5364

Commit Summary

OpenSslEngine writePlaintextData WANT_READ with no data in BIO buffer
File Changes

M handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java (71)
Patch Links:

https://github.com/netty/netty/pull/5364.patch
https://github.com/netty/netty/pull/5364.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[Scottmitch]

Cherry-picked 4.1 (9e2c400) 4.0 (524156f)