New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure SslHandler.sslCloseFuture() is notified in all cases. #6239

Closed
wants to merge 1 commit into
base: 4.1
from

Conversation

Projects
None yet
2 participants
@normanmaurer
Member

normanmaurer commented Jan 18, 2017

Motivation:

The SslHandler.sslCloseFuture() may not be notified when the Channel is closed before a closify_notify is received.

Modifications:

Ensure we try to fail the sslCloseFuture() when the Channel is closed.

Result:

Correctly notify the ssl close future.

Ensure SslHandler.sslCloseFuture() is notified in all cases.
Motivation:

The SslHandler.sslCloseFuture() may not be notified when the Channel is closed before a closify_notify is received.

Modifications:

Ensure we try to fail the sslCloseFuture() when the Channel is closed.

Result:

Correctly notify the ssl close future.

@normanmaurer normanmaurer added this to the 4.0.44.Final milestone Jan 18, 2017

@normanmaurer normanmaurer added the defect label Jan 18, 2017

@normanmaurer normanmaurer self-assigned this Jan 18, 2017

@normanmaurer normanmaurer requested review from nmittler, Scottmitch and trustin Jan 18, 2017

@normanmaurer

This comment has been minimized.

Show comment
Hide comment
@normanmaurer

normanmaurer Jan 19, 2017

Member

Cherry-picked into 4.1 (d37702a) and 4.0 (876818a)

Member

normanmaurer commented Jan 19, 2017

Cherry-picked into 4.1 (d37702a) and 4.0 (876818a)

@normanmaurer normanmaurer deleted the ssl_close_future branch Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment