Correct typo in artifactId of dependency in bom pom.xml

[normanmaurer]

Motivation:

There was a typo in a dependency in the bom pom.xml which lead to have it specify a non-existing artifact and also so not have the maven release plugin update the version correctly.

Modifications:

Rename netty-transport-unix-common to netty-transport-native-unix-common and also fix the version.

Result:

Fixes [#6979]

[normanmaurer]

@tsachev and @wilkinsona PTAL ... This should fix [#6979]

[Scottmitch]

lgtm

[Scottmitch]

I thought we had this at one point though ... and there was something with the release process that prevented using the variable? I may be confusing some other issue though...

[wilkinsona]

That was my concern too. It looks fine in terms of using the variable consistently, but I don't know anything about Netty's release process so I also don't know if it'll work as intended.

[normanmaurer]

@Scottmitch @wilkinsona the problem is that if we use the version directly the maven release plugin will NOT update the version for the dependencies that also have the classifier listed. So I think this is the way to go and also "consistent" with how we add the dependencies in the all module.

[tsachev]

I do not have an opinion on using project.version (unless it makes the bom useless as parent, but that is not its purpose anyway).
There might be something in the release process that replaces ${project.version} with the actual project version I don't know.

But #6979 is about using wrong artifactId which manifests itself in the bom, because maven-release-plugin does not see this non existing module and fails to update them.

<artifactId>netty-transport-unix-common</artifactId> should become <artifactId>netty-transport-native-unix-common</artifactId> everywhere. Note the missing native in the name.

[normanmaurer]

@tsachev doh! I missed this ... so I think this is the real issue then.. Let me update the pr to just fix the artifactId, this should be good enough.

[normanmaurer]

@Scottmitch @wilkinsona @tsachev PTAL again

[wilkinsona]

LGTM

[normanmaurer]

Cherry-picked into 4.1 (deb5c45) and committed a updated version to 4.0 (ae66f3a)

[Scottmitch]

lgtm