Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SslHandler promise completion incorrect if write doesn't immediately #7380

Closed
wants to merge 1 commit into from

Commits on Nov 7, 2017

  1. SslHandler promise completion incorrect if write doesn't immediately

    complete
    
    Motivation:
    SslHandler removes a Buffer/Promise pair from
    AbstractCoalescingBufferQueue when wrapping data. However it is possible
    the SSLEngine will not consume the entire buffer. In this case
    SslHandler adds the Buffer back to the queue, but doesn't add the
    Promise back to the queue. This may result in the promise completing
    immediately in finishFlush, and generally not correlating to the
    completion of writing the corresponding Buffer
    
    Modifications:
    - AbstractCoalescingBufferQueue#addFirst should also support adding the
    ChannelPromise
    - In the event of a handshake timeout we should immediately fail pending
    writes immediately to get a more accurate exception
    
    Result:
    Fixes netty#7378.
    Scottmitch committed Nov 7, 2017
    Copy the full SHA
    ae58af8 View commit details
    Browse the repository at this point in the history