Set stream ID to the real value in Http2StreamFrameToHttpObjectCodec #7778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a unit test as well ?
… Am 13.03.2018 um 10:13 schrieb Jörg Prante ***@***.***>:
Motivation:
Http2StreamFrameToHttpObjectCodec is useful to convert HTTP/2 streams to Netty's HTTP requests/responses. But the HTTP/2 stream ID is always 0 after conversion.
Modification:
Instead of always using 0 for the stream ID, the stream ID from frame.stream().id() is used.
Result:
The stream ID is set from the HTTP/2 stream and retained after conversion. This can be useful for users who wants to track HTTP/2 requests/responses, for example via header x-http2-stream-id.
This is a single line change. I think the contribution is so trivial that I did not sign the CLA yet.
You can view, comment on, or merge this pull request online at:
#7778
Commit Summary
set stream ID to the real value
File Changes
M codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodec.java (2)
Patch Links:
https://github.com/netty/netty/pull/7778.patch
https://github.com/netty/netty/pull/7778.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Yes, but it will take a little while. Seems tests are throwing NPE, not sure why. |
|
@jprante I guess |
|
And thanks for the fix ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Http2StreamFrameToHttpObjectCodec is useful to convert HTTP/2 streams to Netty's HTTP requests/responses. But the HTTP/2 stream ID is always 0 after conversion.
Modification:
Instead of always using 0 for the stream ID, the stream ID from frame.stream().id() is used.
Result:
The stream ID is set from the HTTP/2 stream and retained after conversion. This can be useful for users who wants to track HTTP/2 requests/responses, for example via header x-http2-stream-id.
This is a single line change. I think the contribution is so trivial that I did not sign the CLA yet.