Allow to schedule tasks up to Long.MAX_VALUE #7972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
schedule_delay
branch
from
a1ca3ac
to
a0cc1c8
Compare
|
@carl-mastrangelo @ejona86 I think this is the correct fix. |
| @@ -237,7 +236,7 @@ private int epollWait(boolean oldWakeup) throws IOException { | |||
| long totalDelay = delayNanos(System.nanoTime()); | |||
| int delaySeconds = (int) min(totalDelay / 1000000000L, Integer.MAX_VALUE); | |||
| return Native.epollWait(epollFd, events, timerFd, delaySeconds, | |||
| (int) min(totalDelay - delaySeconds * 1000000000L, Integer.MAX_VALUE)); | |||
| (int) min(MAX_SCHEDULED_TIMERFD_NS, min(totalDelay - delaySeconds * 1000000000L, Integer.MAX_VALUE))); | |||
There was a problem hiding this comment.
I think this can be simplified to drop Integer.MAX_VALUE?
There was a problem hiding this comment.
Sorry not sure I understand... what exactly you propose ?
There was a problem hiding this comment.
return Native.epollWait(epollFd, events, timerFd, delaySeconds,
(int) min(MAX_SCHEDULED_TIMERFD_NS, totalDelay - delaySeconds * 1000000000L));There was a problem hiding this comment.
ah yeah... let me do this
There was a problem hiding this comment.
@carl-mastrangelo PTAL again
Motivation: We should allow to schedule tasks with a delay up to Long.MAX_VALUE as we did pre 4.1.25.Final. Modifications: Just ensure we not overflow and put the correct max limits in place when schedule a timer. At worse we will get a wakeup to early and then schedule a new timeout. Result: Fixes #7970.
normanmaurer
force-pushed
the
schedule_delay
branch
from
a0cc1c8
to
e05df83
Compare
|
@carl-mastrangelo can you validate this one with GRPC as well ? |
|
@normanmaurer I did try to test this out, sadly its pretty time consuming to bring netty into Google if it isn't a released artifact. I think code review is good enough here. |
|
@carl-mastrangelo ok... 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should allow to schedule tasks with a delay up to Long.MAX_VALUE as we did pre 4.1.25.Final.
Modifications:
Just ensure we not overflow and put the correct max limits in place when schedule a timer. At worse we will get a wakeup to early and then schedule a new timeout.
Result:
Fixes #7970.