Deprecate Unpooled.unmodifiableBuffer(ByteBuf...) #8096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Recent PR netty#8040 introduced Unpooled.wrappedUnmodifiableBuffer(ByteBuf...) which has the same behaviour but wraps the provided array directly. This is preferred for most uses (including varargs-based use) and if there are any unusual cases of an explicit array which is re-used before the ByteBuf is finished with, it can just be copied first. Modifications: Added @deprecated annotation and javadoc to Unpooled.unmodifiableBuffer(ByteBuf...). Result: Unpooled.unmodifiableBuffer(ByteBuf...) will be deprecated.
normanmaurer
approved these changes
Jul 7, 2018
|
@njhill thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#8040 introduced
Unpooled.wrappedUnmodifiableBuffer(ByteBuf...)which has the same behaviour but wraps the provided array directly. This is preferred for most uses (including varargs-based use) and if there are any unusual cases of an explicit array which is re-used before theByteBufis finished with, it can just be copied first.Modifications:
Added
@Deprecatedannotation and corresponding javadoc addition toUnpooled.unmodifiableBuffer(ByteBuf...).Result:
Unpooled.unmodifiableBuffer(ByteBuf...)will be deprecated.