Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaks in test introduced by db6d94f82a0f860131392aa483f4d1e21dc74… #8661

Closed
wants to merge 1 commit into from

Conversation

normanmaurer
Copy link
Member

…249.

Motivation:

db6d94f added some testcase which did have a buffer leak and so failed the CI.

Modifications:

Fix leak by proper testing of encoder and decoder using EmbeddedChannel.

Result:

CI is happy again.

Motivation:

db6d94f added some testcase which did have a buffer leak and so failed the CI.

Modifications:

Fix leak by proper testing of encoder and decoder using EmbeddedChannel.

Result:

CI is happy again.
@normanmaurer
Copy link
Member Author

@slandelle FYI... this fixes the leaks introduced by your changes.

@slandelle
Copy link
Contributor

Thanks!

@normanmaurer
Copy link
Member Author

@slandelle hmmm ... now the test suite fails because the autobahntestsuite thinks what we do is not correct:

[ERROR] Failed to execute goal me.normanmaurer.maven.autobahntestsuite:autobahntestsuite-maven-plugin:0.1.4:fuzzingclient (default) on project netty-testsuite-autobahn: 
[ERROR] Failed test cases:
[ERROR] 	[7.9.8] behavior: FAILED, behaviorClose: WRONG_CODE, duration: 2ms, remoteCloseCode: 1014, reportFile: target/autobahntestsuite-reports/autobahntestsuite_maven_plugin_case_7_9_8.json
[ERROR] 	[7.9.6] behavior: FAILED, behaviorClose: WRONG_CODE, duration: 2ms, remoteCloseCode: 1012, reportFile: target/autobahntestsuite-reports/autobahntestsuite_maven_plugin_case_7_9_6.json
[ERROR] 	[7.9.7] behavior: FAILED, behaviorClose: WRONG_CODE, duration: 2ms, remoteCloseCode: 1013, reportFile: target/autobahntestsuite-reports/autobahntestsuite_maven_plugin_case_7_9_7.json

@normanmaurer
Copy link
Member Author

Let me revert your commit for now and we can investigate in your PR then (Please incorporate my test changes in the PR).

@slandelle
Copy link
Contributor

@normanmaurer It looks like autobahn follows RFC6455 strictly and wasn't updated to latest IANA code. Do you want me to reach out to them?

@slandelle
Copy link
Contributor

Can be closed (in favor of #8664)

@normanmaurer
Copy link
Member Author

@slandelle yep why not ... thanks!

@normanmaurer normanmaurer deleted the fix_leaks_in_test branch December 16, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants