Correctly buffer multiple outbound streams if needed. #8694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reported by @angn |
normanmaurer
requested review from
mosesn,
bryce-anderson,
ejona86,
carl-mastrangelo and
trustin
|
@netty-bot test this please |
bryce-anderson
approved these changes
Jan 2, 2019
There was a problem hiding this comment.
It took me a few minutes to figure out why this would result in the stack trace in #8692, which I believe is that when we buffer more than one stream we skip setting the stream property but the connection does actually know about the stream. It might be nice to explain that a bit in the commit message. Then again, maybe it's obvious to everyone else.
ejona86
approved these changes
Jan 12, 2019
|
@bryce-anderson added a comment in the code to explain why a map is needed. |
Motivation: In Http2FrameCodec we made the incorrect assumption that we can only have 1 buffered outboundstream as maximum. This is not correct and we need to account for multiple buffered streams. Modifications: - Use a map to allow buffer multiple streams - Add unit test. Result: Fixes #8692.
normanmaurer
force-pushed
the
buffered_stream_fix
branch
from
c6fb0bb
to
e4a2d06
Compare
normanmaurer
added a commit
that referenced
this pull request
Jan 14, 2019
Motivation: In Http2FrameCodec we made the incorrect assumption that we can only have 1 buffered outboundstream as maximum. This is not correct and we need to account for multiple buffered streams. Modifications: - Use a map to allow buffer multiple streams - Add unit test. Result: Fixes #8692.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In Http2FrameCodec we made the incorrect assumption that we can only have 1 buffered outboundstream as maximum. This is not correct and we need to account for multiple buffered streams.
Modifications:
Result:
Fixes #8692.