[WIP]: Support for more types of DNS records #9070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. A decoder
2. AAAA decoder
2. Text decoder
1. A record
2. NS record
3. CNAME record
4. AAAA record
5. PTR record
|
Because there are dozens of different types of DNS Records, it will take some time to support them all. Currently, only Currently only one basic scaffold has been written, and if there are no problems, I will support more types of DNS Records. |
|
Can one of the admins verify this patch? |
normanmaurer
requested changes
Apr 18, 2019
| /** | ||
| * Decodes the record data. | ||
| */ | ||
| void decodeRdata(); |
There was a problem hiding this comment.
a Record should be just a "Pojo". Decoding does belong to a decoder and not the record
There was a problem hiding this comment.
The decode operation has been moved to the decoder :-). @normanmaurer would you please review it again ?
|
I'll shut down this PR temporarily. When all the functions are tested, I will create a new PR. @normanmaurer thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Current DNS encoding and decoding only supports a few record types (
PTR,OPT), but DNS records have many kinds, such as typeA,NS,CNAMEand so on.Modification:
Add different types of DNS Records and codec
Result:
Fixes #8962