Pre-decompressed DNS record RData that may contain compression pointers #9311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
normanmaurer
requested changes
Jul 1, 2019
codec-dns/src/main/java/io/netty/handler/codec/dns/DnsCodecUtil.java
Outdated
Show resolved
Hide resolved
codec-dns/src/main/java/io/netty/handler/codec/dns/DnsCodecUtil.java
Outdated
Show resolved
Hide resolved
codec-dns/src/main/java/io/netty/handler/codec/dns/DnsCodecUtil.java
Outdated
Show resolved
Hide resolved
codec-dns/src/main/java/io/netty/handler/codec/dns/DnsCodecUtil.java
Outdated
Show resolved
Hide resolved
|
@netty-bot test this please |
normanmaurer
requested changes
Jul 1, 2019
codec-dns/src/main/java/io/netty/handler/codec/dns/DnsCodecUtil.java
Outdated
Show resolved
Hide resolved
normanmaurer
requested changes
Jul 2, 2019
| ByteBuf buffer = Unpooled.wrappedBuffer(compressionPointer); | ||
| ByteBuf uncomporessed = null; | ||
| try { | ||
| uncomporessed = DnsCodecUtil.decompressDomainName(buffer.duplicate().setIndex(10, 12)); |
There was a problem hiding this comment.
nit: typo... should be "uncompressed"
codec-dns/src/test/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoderTest.java
Outdated
Show resolved
Hide resolved
|
@netty-bot test this please |
normanmaurer
approved these changes
Jul 2, 2019
|
@qeesung thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Jul 2, 2019
…rs (#9311) Motivation: When decoding DnsRecord, if the record contains compression pointers, and not all compression pointers are decompressed, but part of the pointers are decompressed. Then when encoding the record, the compressed pointer will point to the wrong location, resulting in bad label problem. Modification: Pre-decompressed record RData that may contain compression pointers. Result: Fixes #8962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When decoding
DnsRecord, if the record contains compression pointers, and not all compression pointers are decompressed, but part of the pointers are decompressed. Then when encoding the record, the compressed pointer will point to the wrong location, resulting in bad label problem.Modification:
Pre-decompressed record RData that may contain compression pointers.
Result:
Fixes #8962