Fix native-build/target/lib wanted but build in native-build/target/lib64 #9410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Since both projects (to some extend) rely on classifier parsing via the os-maven-plugin, they should ideally use the same version in case the parsing changed. Modifications: Upgrade os-maven-plugin from 1.6.0 to 1.6.2 Result: Same os-maven-plugin with same parsing logic.
…ib64
Motivation:
On openSUSE (probably more), 64 bit builds use lib64, e.g. /usr/lib64, and
configure picks this up and builds the native library in
native-build/target/lib64 where maven is not looking.
Modifications:
Explicitly specify --libdir=${project.build.directory}/native-build/target/lib
during configuration.
Result:
Maven uses the correct lib directory.
|
Can one of the admins verify this patch? |
|
@netty-bot test this please |
normanmaurer
pushed a commit
that referenced
this pull request
Aug 7, 2019
…ib64 (#9410) Motivation: On openSUSE (probably more), 64 bit builds use lib64, e.g. /usr/lib64, and configure picks this up and builds the native library in native-build/target/lib64 where maven is not looking. Modifications: Explicitly specify --libdir=${project.build.directory}/native-build/target/lib during configuration. Result: Maven uses the correct lib directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
On openSUSE (probably more), 64 bit builds use
lib64, e.g./usr/lib64, and configure picks this up and builds the native library innative-build/target/lib64where maven is not looking.Modifications:
Based on #9409, this explicitly specifies
--libdir=${project.build.directory}/native-build/target/libduring configuration.Result:
Maven uses the correct lib directory.
This change is