Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle client side http2 upgrades when Http2FrameCodec is used together with Http2MultiplexHandler (9495) #9501

Merged
merged 3 commits into from Aug 23, 2019

Commits on Aug 22, 2019

  1. Correctly handle client side http2 upgrades when Http2FrameCodec is …

    …used together with Http2MultiplexHandler (netty#9495)
    
        Motivation:
    
        In the release (4.1.37) we introduced Http2MultiplexHandler as a
        replacement of Http2MultiplexCodec. This did split the frame parsing from
        the multiplexing to allow a more flexible way to handle frames and to make
        the code cleaner. Unfortunally we did miss to special handle this in
        Http2ClientUpgradeCodec and so did not correctly add Http2MultiplexHandler
        to the pipeline before calling Http2FrameCodec.onHttpClientUpgrade(...).
        This did lead to the situation that we did not correctly receive the event
        on the Http2MultiplexHandler and so did not correctly created the
        Http2StreamChannel for the upgrade stream. Because of this we ended up
        with an NPE if a frame was dispatched to the upgrade stream later on.
    
        Modifications:
    
        - Correctly add Http2MultiplexHandler to the pipeline before calling Http2FrameCodec.onHttpClientUpgrade(...)
    
        Result:
    
        Fixes netty#9495.
        Added Unit Test
    Nizar Mankulangara committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    fcecc4e View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Add missing whitespace

    normanmaurer committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    4780466 View commit details
    Browse the repository at this point in the history
  2. Fix check style

    normanmaurer committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    a9b2485 View commit details
    Browse the repository at this point in the history