Change semantics of EmbeddedChannel to match other transports more cl… #9529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osely. Motiviation: EmbeddedChannel currently is quite differently in terms of semantics to other Channel implementations. We should better change it to be more closely aligned and so have the testing code be more robust. Modifications: - Change EmbeddedEventLoop.inEventLoop() to only return true if we currenlty run pending / scheduled tasks - Change EmbeddedEventLoop.execute(...) to automatically process pending tasks if not already doing so - Adjust a few tests for the new semantics (which is closer to other Channel implementations) Result: EmbeddedChannel works more like other Channel implementations
|
Motivated by #9489 (comment) |
ejona86
approved these changes
Sep 3, 2019
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Jun 24, 2022
Related to Netty 5 change netty/netty#9529 Related to #1873
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Jun 24, 2022
Related to Netty 5 change netty/netty#9529 Related to #1873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…osely.
Motiviation:
EmbeddedChannel currently is quite differently in terms of semantics to other Channel implementations. We should better change it to be more closely aligned and so have the testing code be more robust.
Modifications:
Result:
EmbeddedChannel works more like other Channel implementations