Allow domain sockets to configure SO_SNDBUF and SO_RCVBUF #9584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
transport-native-unix-common/src/main/java/io/netty/channel/unix/DomainSocketChannelConfig.java
Outdated
Show resolved
Hide resolved
transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDomainSocketChannelConfig.java
Show resolved
Hide resolved
normanmaurer
requested changes
Sep 20, 2019
...ort-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueDomainSocketChannelConfig.java
Show resolved
Hide resolved
transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDomainSocketChannelConfig.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review @normanmaurer. I signed the icla and addressed your comments. Let me know if there's anything else you'd like me to follow up with. |
|
I will just do it directly in master as a followup
… Am 20.09.2019 um 15:49 schrieb Joe Ellis ***@***.***>:
@ellisjoe commented on this pull request.
In transport-native-unix-common/src/main/java/io/netty/channel/unix/DomainSocketChannelConfig.java:
> @@ -77,4 +79,24 @@
* Return the ***@***.*** DomainSocketReadMode} for the channel.
*/
DomainSocketReadMode getReadMode();
removed. is there somewhere you'd like to track adding this in a future release?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
normanmaurer
requested changes
Sep 20, 2019
transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDomainSocketChannelConfig.java
Outdated
Show resolved
Hide resolved
...ort-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueDomainSocketChannelConfig.java
Outdated
Show resolved
Hide resolved
|
@netty-bot test this please |
|
@ellisjoe thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Sep 20, 2019
Motivation: Running tests with a `KQueueDomainSocketChannel` showed worse performance than an `NioSocketChannel`. It turns out that the default send buffer size for Nio sockets is 64k while for KQueue sockets it's 8k. I verified that manually setting the socket's send buffer size improved perf to expected levels. Modification: Plumb the `SO_SNDBUF` and `SO_RCVBUF` options into the `*DomainSocketChannelConfig`. Result: Can now configure send and receive buffer sizes for domain sockets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Running tests with a
KQueueDomainSocketChannelshowed worse performance than anNioSocketChannel. It turns out that the default send buffer size for Nio sockets is 64k while for KQueue sockets it's 8k. I verified that manually setting the socket's send buffer size improved perf to expected levels.Modification:
Plumb the
SO_SNDBUFandSO_RCVBUFoptions into theDomainSocketChannelConfig.Result:
Can now configure send and receive buffer sizes for domain sockets.