Remove dependency on GLIBC 2.12 by using syscalls directly #9797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: 394a1b3 introduced a hard dependency on GLIBC 2.12 which was not the case before. This had the effect of not be able to use the native epoll transports on platforms which ship with earlier versions of GLIBC. To make things a backward compatible as possible we should not introduce such changes in a bugfix release. Special thanks to @weissi with all the help to fix this. Modifications: - Use syscalls directly to remove dependency on GLIBC 2.12 - Make code consistent that needs newer GLIBC versions - Adjust scattering read test to only run if recvmmsg syscall is supported - Cleanup pom.xml as some stuff is not needed anymore after using syscalls. Result: Fixes #9758.
|
/cc @ursaj |
njhill
approved these changes
Nov 23, 2019
| } | ||
| return JNI_FALSE; | ||
| return JNI_TRUE; | ||
| } |
There was a problem hiding this comment.
kind of nit suggestion but these methods could be more concise as e.g.
return (syscall(SYS_sendmmsg, -1, NULL, 0, 0) != -1 || errno != ENOSYS) ? JNI_TRUE : JNI_FALSE;There was a problem hiding this comment.
I think it is more readable as it is. So let me keep it
normanmaurer
added a commit
that referenced
this pull request
Nov 23, 2019
Motivation: 394a1b3 introduced a hard dependency on GLIBC 2.12 which was not the case before. This had the effect of not be able to use the native epoll transports on platforms which ship with earlier versions of GLIBC. To make things a backward compatible as possible we should not introduce such changes in a bugfix release. Special thanks to @weissi with all the help to fix this. Modifications: - Use syscalls directly to remove dependency on GLIBC 2.12 - Make code consistent that needs newer GLIBC versions - Adjust scattering read test to only run if recvmmsg syscall is supported - Cleanup pom.xml as some stuff is not needed anymore after using syscalls. Result: Fixes #9758.
normanmaurer
added a commit
that referenced
this pull request
Dec 4, 2019
…vmmsg and sendmmsg usage Motivation: #9797 changed the code for recvmmsg and sendmmsg to use the syscalls directly to remvove the dependency on newer GLIBC versions. Unfortunally it made the assumption that the syscall numbers are the same for different architectures, which is not the case. Thanks to @jayv for pointing it out Modifications: Add #if, #elif and #else declarations to ensure we pick the correct syscall number (or not support if if the architecture is not supported atm). Result: Pick the correct syscall number depending on the architecture.
normanmaurer
added a commit
that referenced
this pull request
Dec 5, 2019
…vmmsg and sendmmsg usage (#9844) Motivation: #9797 changed the code for recvmmsg and sendmmsg to use the syscalls directly to remvove the dependency on newer GLIBC versions. Unfortunally it made the assumption that the syscall numbers are the same for different architectures, which is not the case. Thanks to @jayv for pointing it out Modifications: Add #if, #elif and #else declarations to ensure we pick the correct syscall number (or not support if if the architecture is not supported atm). Result: Pick the correct syscall number depending on the architecture.
normanmaurer
added a commit
that referenced
this pull request
Dec 5, 2019
…vmmsg and sendmmsg usage (#9844) Motivation: #9797 changed the code for recvmmsg and sendmmsg to use the syscalls directly to remvove the dependency on newer GLIBC versions. Unfortunally it made the assumption that the syscall numbers are the same for different architectures, which is not the case. Thanks to @jayv for pointing it out Modifications: Add #if, #elif and #else declarations to ensure we pick the correct syscall number (or not support if if the architecture is not supported atm). Result: Pick the correct syscall number depending on the architecture.
bernd
added a commit
to Graylog2/graylog2-server
that referenced
this pull request
Jan 2, 2020
This is a bug-fix release. One of the important fixes is, that it removes the dependency on a newer glibc version: - Remove dependency on GLIBC 2.12 by using syscalls directly (netty/netty#9797) For more details see the changelog: https://netty.io/news/2019/12/18/4-1-44-Final.html
mpfz0r
pushed a commit
to Graylog2/graylog2-server
that referenced
this pull request
Jan 3, 2020
This is a bug-fix release. One of the important fixes is, that it removes the dependency on a newer glibc version: - Remove dependency on GLIBC 2.12 by using syscalls directly (netty/netty#9797) For more details see the changelog: https://netty.io/news/2019/12/18/4-1-44-Final.html
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
…vmmsg and sendmmsg usage (netty#9844) Motivation: netty#9797 changed the code for recvmmsg and sendmmsg to use the syscalls directly to remvove the dependency on newer GLIBC versions. Unfortunally it made the assumption that the syscall numbers are the same for different architectures, which is not the case. Thanks to @jayv for pointing it out Modifications: Add #if, #elif and #else declarations to ensure we pick the correct syscall number (or not support if if the architecture is not supported atm). Result: Pick the correct syscall number depending on the architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
394a1b3 introduced a hard dependency on GLIBC 2.12 which was not the case before. This had the effect of not be able to use the native epoll transports on platforms which ship with earlier versions of GLIBC.
To make things a backward compatible as possible we should not introduce such changes in a bugfix release.
Special thanks to @weissi with all the help to fix this.
Modifications:
Result:
Fixes #9758.