Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection/socket timeout has an infinite value? #240

Closed
jonua opened this issue Dec 17, 2019 · 3 comments
Closed

connection/socket timeout has an infinite value? #240

jonua opened this issue Dec 17, 2019 · 3 comments

Comments

@jonua
Copy link

jonua commented Dec 17, 2019

Looks like the URLFetcher has a default values (infinite) for a connection/socket timeout. Right?

@stevehu
Copy link
Contributor

stevehu commented Dec 17, 2019

Yes. The fetcher is a very simple implementation and assumes a lot of conditions. We should create an exception upon timeout and convert it into a validation error somehow. Do you have any better ideas?

@jonua
Copy link
Author

jonua commented Dec 20, 2019

In my implementation of a custom URLFetcher I use a unirest instance with timeout. But this is hardly a good idea for a library - additional dependency will complicate implementation

@stevehu
Copy link
Contributor

stevehu commented Dec 20, 2019

@this is good enough. I just want the users to know that the default implementation is simple and works for normal scenarios; however, it doesn't handle all possible exceptions. There is a way to substitute with customized implementations. I will write a document for this. Thanks.

@jonua jonua closed this as completed Dec 20, 2019
@jonua jonua reopened this Dec 20, 2019
@stevehu stevehu closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants