-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow edge style to be a list of styles for DiGraphs #5131
Conversation
Thanks for this idea and for the code! :} Could you make the if/else logic match that for |
Hi Dan, updated the logic style and added some tests. Let me know if you need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mgbckr , this seems like an obvious improvement to me!
I had a couple suggestions about cleaning up the logic a bit and making the added tests a bit more rigorous. One other thing is that the style
parameter in the Parameters
list of the draw_networkx_edges
docstring should be updated to reflect this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks @mgbckr !
Support sequences of linestyles for directed edges in `draw_networkx_edges`.
Support sequences of linestyles for directed edges in `draw_networkx_edges`.
Support sequences of linestyles for directed edges in `draw_networkx_edges`.
Fixes issue where
DiGraph
s fail to allow a list of edge styles (or when enablingarrows=True
forGraph
):This throws an error:
The proposed pull request fixes this issue.