Changed arguments list of GraphMLWriterLxml.dump() #6261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed arguments list of GraphMLWriterLxml.dump to be consistent with the type of GraphMLWriter.dump. (Otherwise, if we have some GraphMLWriterLxml A, and some user calls A.dump(stream) (maybe in the context of a function which takes a GraphMLWriter) then it will call the method of the parent class rather than that of the child class.) This also makes static analysis tools happier, which reduces the amount of things to look at when debugging.
MridulS
approved these changes
Nov 11, 2023
rossbar
approved these changes
Nov 11, 2023
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
Changed arguments list of GraphMLWriterLxml.dump to be consistent with the type of GraphMLWriter.dump. (Otherwise, if we have some GraphMLWriterLxml A, and some user calls A.dump(stream) (maybe in the context of a function which takes a GraphMLWriter) then it will call the method of the parent class rather than that of the child class.) This also makes static analysis tools happier, which reduces the amount of things to look at when debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed arguments list of GraphMLWriterLxml.dump to be consistent with the type of GraphMLWriter.dump. Otherwise, if we have some GraphMLWriterLxml A, and some user calls A.dump(stream) (maybe in the context of a function which takes a GraphMLWriter) then it will throw an error.
This also makes static analysis tools happier, which reduces the amount of things to look at when debugging.