Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed arguments list of GraphMLWriterLxml.dump() #6261

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Changed arguments list of GraphMLWriterLxml.dump() #6261

merged 1 commit into from
Nov 11, 2023

Commits on Dec 7, 2022

  1. Changed arguments list of GraphMLWriterLxml.dump() 

    Changed arguments list of GraphMLWriterLxml.dump to be consistent with the type of GraphMLWriter.dump.
(Otherwise, if we have some GraphMLWriterLxml A, and some user calls A.dump(stream) (maybe in the context of a function which takes a GraphMLWriter) then it will call the method of the parent class rather than that of the child class.)
This also makes static analysis tools happier, which reduces the amount of things to look at when debugging.
    @patrick-nicodemus
    patrick-nicodemus committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b0defbd View commit details
    Browse the repository at this point in the history