tweak test_override_dispatch to allow G keyword
#6499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple follow-up to networkx#6471, and, as in that PR, this fix is short term. We would like to find a more elegant, robust solution (probably after nx 3.1). I sometimes forget there are two versions of `_dispatch`, and this PR fixes the one that gets used when `NETWORKX_GRAPH_CONVERT` environment variable is set. NetworkX does not yet test `test_override_dispatch`, so it's not easy to add a test, but it gets used by external backends such as `graphblas_algorithms`. Ideally, we should test this in NetworkX, which will require calling subprocess in a test with an environment variable set.
dschult
approved these changes
Mar 13, 2023
Alex-Markham
pushed a commit
to Alex-Markham/networkx
that referenced
this pull request
Oct 13, 2023
This is a simple follow-up to networkx#6471, and, as in that PR, this fix is short term. We would like to find a more elegant, robust solution (probably after nx 3.1). I sometimes forget there are two versions of `_dispatch`, and this PR fixes the one that gets used when `NETWORKX_GRAPH_CONVERT` environment variable is set. NetworkX does not yet test `test_override_dispatch`, so it's not easy to add a test, but it gets used by external backends such as `graphblas_algorithms`. Ideally, we should test this in NetworkX, which will require calling subprocess in a test with an environment variable set.
dschult
pushed a commit
to BrunoBaldissera/networkx
that referenced
this pull request
Oct 23, 2023
This is a simple follow-up to networkx#6471, and, as in that PR, this fix is short term. We would like to find a more elegant, robust solution (probably after nx 3.1). I sometimes forget there are two versions of `_dispatch`, and this PR fixes the one that gets used when `NETWORKX_GRAPH_CONVERT` environment variable is set. NetworkX does not yet test `test_override_dispatch`, so it's not easy to add a test, but it gets used by external backends such as `graphblas_algorithms`. Ideally, we should test this in NetworkX, which will require calling subprocess in a test with an environment variable set.
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
This is a simple follow-up to networkx#6471, and, as in that PR, this fix is short term. We would like to find a more elegant, robust solution (probably after nx 3.1). I sometimes forget there are two versions of `_dispatch`, and this PR fixes the one that gets used when `NETWORKX_GRAPH_CONVERT` environment variable is set. NetworkX does not yet test `test_override_dispatch`, so it's not easy to add a test, but it gets used by external backends such as `graphblas_algorithms`. Ideally, we should test this in NetworkX, which will require calling subprocess in a test with an environment variable set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple follow-up to #6471, and, as in that PR, this fix is short term. We would like to find a more elegant, robust solution (probably after nx 3.1).
I sometimes forget there are two versions of
_dispatch, and this PR fixes the one that gets used whenNETWORKX_GRAPH_CONVERTenvironment variable is set. NetworkX does not yet testtest_override_dispatch, so it's not easy to add a test, but it gets used by external backends such asgraphblas_algorithms. Ideally, we should test this in NetworkX, which will require calling subprocess in a test with an environment variable set.CC @MridulS @jim22k