Update test suite for Pytest v8 #7203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschult
approved these changes
Jan 4, 2024
jarrodmillman
approved these changes
Jan 4, 2024
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Feb 1, 2024
…dds updates for pytest 8 compat, temporarily skips IO intensive test in CI (#4121) * Adds option to rapids_cpm_find for raft to disable hnswlib feature, which is not needed by cugraph. This resolves cmake failures such as the following: ``` CMake Error at /home/coder/cugraph/cpp/build/release/_deps/raft-build/raft-targets.cmake:56 (set_target_properties): The link interface of target "raft::raft" contains: hnswlib::hnswlib but the target was not found. ``` * TEMPORARILY skips bulk sampling IO tests which were hanging on CI runners. These tests pass locally, so we believe this is related to IO issues on CI runners, but will investigate further in 24.04 * Adds updates for pytest >=8 * Adds option to pytest to append source paths to PYTHONPATH instead of prepend (the default). The prepended PYTHONPATH caused the dask `LocalCUDACluster` to import cugraph modules from the source tree instead of the install location, which resulted in `ImportError`s. This appears to be a behavior change in pytest 8. * Adds an `xfail` for an [NX test known to be incompatible with pytest>=8](networkx/networkx#7203) Authors: - Rick Ratzel (https://github.com/rlratzel) Approvers: - Divye Gala (https://github.com/divyegala) - Chuck Hastings (https://github.com/ChuckHastings) - Ray Douglass (https://github.com/raydouglass) - Erik Welch (https://github.com/eriknw) URL: #4121
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
* Rm deprecated_call filter from strongly connected raises test. * Replace deprecated pytest.warns(None) with catch_warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a release candidate for Pytest v8 for which two of NX's tests were failing. This PR makes the necessary updates to be pytest-8 compatible:
pytest.deprecated_callcheck from a test which raises an exception. It turns out this never raised the warning as it hits the exception first, it's just that pytest v7 never caught this case.pytest.warns(None)pattern with the recommendedwarnings.catch_warnings()context manager.