Undeprecate nx_pydot now that pydot is actively maintained again
#7204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dschult
approved these changes
Jan 4, 2024
|
The test failures are fixed by #7203 |
jarrodmillman
approved these changes
Jan 4, 2024
tomwhite
added a commit
to cubed-dev/cubed
that referenced
this pull request
Apr 15, 2024
tomwhite
added a commit
to cubed-dev/cubed
that referenced
this pull request
Apr 15, 2024
tomwhite
added a commit
to cubed-dev/cubed
that referenced
this pull request
Apr 16, 2024
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…etworkx#7204) * Un-xfail pydot tests. * Pin pydot minver to 2.0. * Rm deprecation bullet from devdocs. * Back out deprecation warnings for nx_pydot. --------- Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #5723, pydot has a new lease on life. I test
nx_pydotagainst the new pydot 2.0 release and the issues that NX had been running into are now all resolved.Given that
pydotis again under active maintenance, I'm +1 on undeprecating and continuing to support NetworkX's interface topydot.Closes #5723