Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect order of text strings when right-click pasting in pwsh on Windows #605

Closed
o-sdn-o opened this issue Jul 18, 2024 · 2 comments · Fixed by #606 or #608
Closed

Incorrect order of text strings when right-click pasting in pwsh on Windows #605

o-sdn-o opened this issue Jul 18, 2024 · 2 comments · Fixed by #606 or #608
Labels
bug Something isn't working regression Terminal Built-in terminal emulator UX User Experience

Comments

@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Jul 18, 2024

When pasting multi-line text from the clipboard, vtm adds a soft line-break to the end of each line by adding a pressed Ctrl modifier. When I did this with the addition of the Shift modifier, it turned out that Shift+Enter is used by Far Manager as its own shortcut macro. In the end, I decided to do Ctrl+Enter, but I didn’t notice that in pwsh Ctrl+Enter changes the order of lines when inserting, since new lines are added from the top and not from the bottom.

xlink: microsoft/terminal#15508

@o-sdn-o o-sdn-o added bug Something isn't working Terminal Built-in terminal emulator UX User Experience regression labels Jul 18, 2024
@o-sdn-o
Copy link
Collaborator Author

o-sdn-o commented Jul 18, 2024

Using Alt+Shift+Enter as a soft line break changes Far Manager's behavior to what is needed and keeps pwsh intact.

@o-sdn-o
Copy link
Collaborator Author

o-sdn-o commented Jul 19, 2024

I decided to add a Shift modifier for soft line breaks only if mouse reporting is off.

  • It turns out that Far Manager receives a clean Enter press on multi-line paste, since it uses mouse reporting.
  • pwsh gets Shift+Enter because mouse reporting is off there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Terminal Built-in terminal emulator UX User Experience
Projects
None yet
1 participant