Rename DTO secret attribute to codeChallenge

netzbegruenung · Nov 29, 2023 · 401b45a · 401b45a
1 parent d2ae4da
commit 401b45a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/app-authenticator/src/main/java/netzbegruenung/keycloak/app/dto/ChallengeDto.java b/app-authenticator/src/main/java/netzbegruenung/keycloak/app/dto/ChallengeDto.java
@@ -11,20 +11,20 @@ public class ChallengeDto implements Serializable {
 	private final String userFirstName;
 	private final String userLastName;
 	private final String targetUrl;
-	private final String secret;
+	private final String codeChallenge;
 	private final Long updatedTimestamp;
 	private final String ipAddress;
 	private final String device;
 	private final String browser;
 	private final String os;
 	private final String osVersion;
 
-	public ChallengeDto(String userName, String userFirstName, String userLastName, String targetUrl, String secret, Long updatedTimestamp, String ipAddress, String device, String browser, String os, String osVersion) {
+	public ChallengeDto(String userName, String userFirstName, String userLastName, String targetUrl, String codeChallenge, Long updatedTimestamp, String ipAddress, String device, String browser, String os, String osVersion) {
 		this.userName = userName;
 		this.userFirstName = userFirstName;
 		this.userLastName = userLastName;
 		this.targetUrl = targetUrl;
-		this.secret = secret;
+		this.codeChallenge = codeChallenge;
 		this.updatedTimestamp = updatedTimestamp;
 		this.ipAddress = ipAddress;
 		this.device = device;
@@ -49,8 +49,8 @@ public String getTargetUrl() {
 		return targetUrl;
 	}
 
-	public String getSecret() {
-		return secret;
+	public String getCodeChallenge() {
+		return codeChallenge;
 	}
 
 	public Long getUpdatedTimestamp() {
@@ -86,7 +86,7 @@ public boolean equals(Object o) {
 			Objects.equals(this.userFirstName, entity.userFirstName) &&
 			Objects.equals(this.userLastName, entity.userLastName) &&
 			Objects.equals(this.targetUrl, entity.targetUrl) &&
-			Objects.equals(this.secret, entity.secret) &&
+			Objects.equals(this.codeChallenge, entity.codeChallenge) &&
 			Objects.equals(this.updatedTimestamp, entity.updatedTimestamp) &&
 			Objects.equals(this.ipAddress, entity.ipAddress) &&
 			Objects.equals(this.device, entity.device) &&
@@ -97,6 +97,6 @@ public boolean equals(Object o) {
 
 	@Override
 	public int hashCode() {
-		return Objects.hash(userName, userFirstName, userLastName, targetUrl, secret, updatedTimestamp, ipAddress, device, browser, os, osVersion);
+		return Objects.hash(userName, userFirstName, userLastName, targetUrl, codeChallenge, updatedTimestamp, ipAddress, device, browser, os, osVersion);
 	}
-}
+}
diff --git a/...nticator/src/main/java/netzbegruenung/keycloak/app/messaging/MessagingServiceFactory.java b/...nticator/src/main/java/netzbegruenung/keycloak/app/messaging/MessagingServiceFactory.java
@@ -14,7 +14,7 @@ public static MessagingService get(Map<String, String> config) {
 				logger.infov(
 					"Simulation mode - send authentication request: action Url {0}, challenge {1}, device push ID {2}, user {3}",
 					challengeDto.getTargetUrl(),
-					challengeDto.getSecret(),
+					challengeDto.getCodeChallenge(),
 					devicePushId,
 					challengeDto.getUserName()
 				);