Implement global context server mixin feature #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the concept of a global context asset. This is a special asset that contains extensions to `HAML.globals`. This asset is mixed into the javascript environment before compilation on the server - allowing us to share custom `HAML.globals` on both client and server. The path for this asset is configurable.
When the global_context_asset changes rails should recompile stale hamlc templates. By default, rails only recompiles templates if they're touched, which is problematic since it's the helper not the template that changed. This commit patches rails so that it automatically recompiles and touches hamlc templates when the global_context_asset changes from underneath it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of the feature discussed in #85.