Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements when indexing through Applications #518

Closed
davidmezzetti opened this issue Aug 9, 2023 · 0 comments
Closed

Improvements when indexing through Applications #518

davidmezzetti opened this issue Aug 9, 2023 · 0 comments
Assignees
Milestone

Comments

@davidmezzetti
Copy link
Member

davidmezzetti commented Aug 9, 2023

Make the following improvements to help indexing through applications.

  • In Application.add, cast the input documents batch to a list. This will automatically convert a generator if that's provided. Note that this method is designed to work with small batches, not the entire dataset

  • Default graph and topics configuration if it's None. This is the same logic already available in scoring. This makes it possible to have cleaner input YAML syntax.

@davidmezzetti davidmezzetti added this to the v6.0.0 milestone Aug 9, 2023
@davidmezzetti davidmezzetti self-assigned this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant