-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a wrapper to create SparseAutoModelForCausalLM.from_pretrained
#2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
previously approved these changes
Jan 25, 2024
dbogunowicz
commented
Jan 25, 2024
dbogunowicz
commented
Jan 25, 2024
mgoin
reviewed
Jan 25, 2024
rahul-tuli
approved these changes
Jan 26, 2024
rahul-tuli
reviewed
Jan 26, 2024
rahul-tuli
previously requested changes
Jan 26, 2024
Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
…ic/sparseml into feature/damian/sparseautomodel
bfineran
reviewed
Jan 29, 2024
Satrat
reviewed
Jan 31, 2024
bfineran
previously approved these changes
Feb 1, 2024
rahul-tuli
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending comment
dbogunowicz
commented
Feb 2, 2024
rahul-tuli
approved these changes
Feb 2, 2024
bfineran
approved these changes
Feb 2, 2024
dbogunowicz
added a commit
that referenced
this pull request
Feb 2, 2024
…ined` (#2010) * initial commit * private functions in the bottom of the script * typo * typo2 * add support for downloading recipe from hf directly * Update src/sparseml/transformers/utils/helpers.py Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * Update src/sparseml/transformers/utils/helpers.py Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * add sparsezoo model support * make resolve recipe function more bulletproof * fix tests * address PR comments * thorough refactor of the resolve_recipe logic * Update src/sparseml/transformers/utils/helpers.py --------- Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
bfineran
pushed a commit
that referenced
this pull request
Feb 2, 2024
…ined` (#2010) * initial commit * private functions in the bottom of the script * typo * typo2 * add support for downloading recipe from hf directly * Update src/sparseml/transformers/utils/helpers.py Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * Update src/sparseml/transformers/utils/helpers.py Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * add sparsezoo model support * make resolve recipe function more bulletproof * fix tests * address PR comments * thorough refactor of the resolve_recipe logic * Update src/sparseml/transformers/utils/helpers.py --------- Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
SparseAutoModel
to augmenttransformers.AutoModel
The most important feature is the refactor of
resolve_recipe
function, that is more thorough and robust.