Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove yaml list key for API_QUERY_URL #164

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Sep 6, 2023

Closes #163

Changes proposed in this pull request:

  • remove the dash

Possibly still to be done:

  • confirm this is actually a yaml-list (i.e. - dash) issue
  • can we test this so it doesn't happen again?

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs surchs self-assigned this Sep 6, 2023
@surchs surchs added bug:functional Functional defects resulting from feature changes. severity:blocker A bug or broken feature with no workaround type:bug Defects in shipped code and fixes for those defects labels Sep 6, 2023
@alyssadai alyssadai self-requested a review September 6, 2023 19:45
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @surchs 💪

Re:

can we test this so it doesn't happen again?

The easiest solution would probably be to add to our pre-commit config a hook to validate the docker compose config file itself, i.e.

@surchs surchs merged commit 126e5ac into main Sep 6, 2023
7 checks passed
@surchs surchs deleted the iss163/fix-docker-compose branch September 6, 2023 20:00
@surchs
Copy link
Contributor Author

surchs commented Sep 6, 2023

Thanks for the quick fix @surchs 💪

Re:

can we test this so it doesn't happen again?

The easiest solution would probably be to add to our pre-commit config a hook to validate the docker compose config file itself, i.e.

Yeah I think that's a really good idea, could you make an issue and then we address that maybe for the dsst milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:functional Functional defects resulting from feature changes. severity:blocker A bug or broken feature with no workaround type:bug Defects in shipped code and fixes for those defects
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

docker compose env var for shell substitution is incorrect
2 participants