Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add Neurobagel vocab graph file #184

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Sep 22, 2023

Closes #182

Reference for our currently used classes: https://github.com/neurobagel/bagel-cli/blob/main/bagel/models.py

See also #185 for suggested modification of add_data_to_graph.sh to support uploading vocab files to the graph

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@coveralls
Copy link
Collaborator

coveralls commented Sep 22, 2023

Pull Request Test Coverage Report for Build 6279464709

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.754%

Totals Coverage Status
Change from base Build 6279413011: 0.0%
Covered Lines: 405
Relevant Lines: 406

💛 - Coveralls

@surchs surchs self-requested a review September 25, 2023 16:22
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @alyssadai 🧑‍🍳

@alyssadai alyssadai merged commit 2a6fc31 into main Sep 25, 2023
4 checks passed
@alyssadai alyssadai deleted the feat-182/add-nb-vocab branch September 25, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .ttl file for Neurobagel controlled term class relationships
3 participants