Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Update aggregate response body #193

Merged
merged 4 commits into from
Sep 28, 2023
Merged

[ENH] Update aggregate response body #193

merged 4 commits into from
Sep 28, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Sep 28, 2023 •
edited by surchs
Loading

Closes #171
Closes #192

Changes proposed in this pull request:

  • Session paths now provided as dictionaries
  • New boolean key records_protected added to indicate whether API is set up to return aggregate results

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai changed the title Update aggregate response body [ENH] Update aggregate response body Sep 28, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6343527686

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.754%
Totals Coverage Status
Change from base Build 6339917280: 0.0%
Covered Lines: 406
Relevant Lines: 407
💛 - Coveralls

surchs
surchs approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
🧑‍🍳

rmanaem
rmanaem approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit 03f5d5d into main Sep 28, 2023
4 of 5 checks passed
@alyssadai alyssadai deleted the update-agg-response branch September 28, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alyssadai @coveralls @surchs @rmanaem